Spelling #4209

jsoref · 2026-01-25T06:23:38Z

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/actions-runner/actions/runs/21328179241/attempts/1

The action reports that the changes in this PR would make it mostly happy: https://github.com/jsoref/actions-runner/actions/runs/21328179502/attempts/1

Fixes Error Logs Spelling Mistake #4205

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2026-01-25T06:29:16Z

src/Test/L0/Worker/JobExtensionL0.cs

        [Trait("Level", "L0")]
        [Trait("Category", "Worker")]
-        public async Task UploadDiganosticLogIfEnvironmentVariableSet()
+        public async Task UploadDiagnosticLogIfEnvironmentVariableSet()


-Diganostic +Diagnostic

jsoref · 2026-01-25T06:29:22Z

src/Test/L0/Listener/Configuration/RunnerCredentialL0.cs

        public override VssCredentials GetVssCredentials(IHostContext context, bool allowAuthUrlV2)
        {
-            Tracing trace = context.GetTrace("OuthAccessToken");
+            Tracing trace = context.GetTrace("OAuthAccessToken");


jsoref · 2026-01-25T06:29:24Z

src/Test/L0/Listener/Configuration/RunnerCredentialL0.cs

        }
    }
-}
+}


vscode made me do it?

jsoref · 2026-01-25T06:29:30Z

src/Sdk/WorkflowParser/WorkflowTemplateParser.cs

@@ -1,4 +1,4 @@
-#nullable disable // Consider removing in the future to minimize likelihood of NullReferenceException; refer https://learn.microsoft.com/en-us/dotnet/csharp/nullable-references
+#nullable disable // Consider removing in the future to minimize likelihood of NullReferenceException; refer https://learn.microsoft.com/en-us/dotnet/csharp/nullable-references


I'm not at all sure why these lines are considered different

jsoref · 2026-01-25T06:35:29Z

src/Runner.Listener/JobDispatcher.cs

                    else
                    {
-                        // retry till reach lockeduntil + 5 mins extra buffer.
+                        // retry until locked-until + 5 mins extra buffer.


till is a really odd word to use...

jsoref · 2026-01-25T06:36:46Z

src/Runner.Plugins/Repository/v1.1/GitSourceProvider.cs


            // fetch lfs object upfront, this will avoid fetch lfs object during checkout which cause checkout taking forever
-            // since checkout will fetch lfs object 1 at a time, while git lfs fetch will fetch lfs object in parallel.
+            // since checkout will fetch lfs object one at a time, while git lfs fetch will fetch lfs object in parallel.


There's a general rule that discourages using small numbers (1). I haven't applied that rule completely, but In cases of 1 at a time which is really the phrase one-at-a-time, I have replaced 1 with one.

MikeMcC399 · 2026-02-08T18:23:00Z

@jsoref

You've done a lot of work here! I wonder if you've noticed https://github.com/actions/runner/blob/main/README.md#note where it says:

Thank you for your interest in this GitHub repo, however, right now we are not taking contributions.

One of the maintainers might like to comment if this is still the current situation.

jsoref · 2026-02-08T18:31:33Z

I spoke with one of the team members in December. The short of it is that they allocated a lot of resources on something that didn't work out and that starved their capacity to properly maintain their repositories. The item in the read me is their attempt at honesty. They do hope to work on the backlog of contributions for at least one repository (by Q2? I can't remember) and get things in shape and then keep it that way and work on another.

They hadn't made a definite decision as to which repository, but this was one they were considering.

The other repositories in the organization probably also should have the same note but they didn't allocate the resources to do that.

jsoref · 2026-02-09T04:46:20Z

I should note that the work I did in this PR is fairly cheap for me. I do it quite often as it exercises the product I'm developing. Each time I do so is a chance for me to improve things – i.e. I learn and my product improves whether or not a PR is made or merged.

For this repository, I have had a PR merged since that notice was added, although it was admittedly a smaller PR.

salmanmkc · 2026-02-09T22:33:21Z

docs/checks/sslcert.md

    - macOS: ![trust ca cert](./../res/macOStrustCA.gif)
    - Linux: Refer to the distribution documentation
-      1. RedHat: https://www.redhat.com/sysadmin/ca-certificates-cli
+      1. Red Hat: https://www.redhat.com/sysadmin/ca-certificates-cli


wow thanks, TIL https://www.redhat.com/en/about/brand/standards/naming-and-trademarks#:~:text=Referring%20to%20Red%20Hat&text=Do%20this%3A%20Type%20Red%20Hat,use%20the%20words%20in%20lowercase.

salmanmkc · 2026-02-09T22:35:21Z

scripts/create-latest-svc.sh


 #---------------------------------------
-# Unattend config
+# Unattended config


I think unattend is intentional here, for example: https://learn.microsoft.com/en-us/windows-hardware/manufacture/desktop/update-windows-settings-and-scripts-create-your-own-answer-file-sxs?view=windows-11

Thoughts? @TingluoHuang

Yeah, I remember unattend for Windows from ages ago.

I figured that while it might technically refer to a thing, unless someone was referring to a file in which case they could spell out the filename (unattend.xml), they should use a human readable term.

src/Runner.Common/Util/TaskResultUtil.cs

src/Runner.Listener/Configuration/ConfigurationManager.cs

src/Runner.Listener/Configuration/WindowsServiceControlManager.cs

src/Runner.Service/Windows/RunnerService.cs

src/Runner.Worker/Handlers/ScriptHandler.cs

salmanmkc · 2026-02-09T22:54:22Z

src/Sdk/Common/Common/Utility/UriUtility.cs

        /// <remarks>
        /// "x-mvwit" is here as it is used and saved to work item history rich HTML changes. It is used to reference other work
-        /// items in the list. If we remove it from this list, it will not be a navigatable link in e.g. Web Access.
+        /// items in the list. If we remove it from this list, it will not be a navigable link in e.g. Web Access.


wow TIL this as well

src/Sdk/Common/Common/Utility/UriUtility.cs

salmanmkc · 2026-02-09T22:55:18Z

src/Sdk/Common/Common/Utility/UriUtility.cs

        /// <returns>The base Uri with the relativePath appended to it.</returns>
        /// <remarks> 
-        /// This is intended to be an alternative the Uri constructor, which can remove several path segments from your arguments.  For example:
+        /// This is intended to be an alternative to the Uri constructor, which can remove several path segments from your arguments.  For example:


Suggested change

/// This is intended to be an alternative to the Uri constructor, which can remove several path segments from your arguments. For example:

/// This is intended to be an alternative to the URI constructor, which can remove several path segments from your arguments. For example:

salmanmkc · 2026-02-09T22:56:44Z

I will continue reviewing at another point since almost midnight, getting tired but thanks so much for this @jsoref, nice to see you here!

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 4 commits January 25, 2026 00:56

link: actions/runner#...

73805dd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

link: joelparkerhenderson/architecture-decision-record

fe556c5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

link: dotnet load SSL CA certificates on each OS

d492893

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

link: automate your use of self-hosted runners

4e982fe

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref requested a review from a team as a code owner January 25, 2026 06:23

jsoref commented Jan 25, 2026

View reviewed changes