Conversation
|
Hi @jsoref , |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
@priyagupta108: I've rebased + refreshed. As you've ignored this PR for literally a year, I look forward to your prompt review. |
| check-latest: | ||
| description: 'Set this option to true if you want the action to always check for the latest available version that satisfies the version spec' | ||
| default: false | ||
| default: 'false' |
There was a problem hiding this comment.
This is a yaml file and github's action syntax asserts that the default field is a string, but false (and true) would be parsed as booleans by yaml parsers which makes parsers very upset.
The correct thing to do to make the parsers happy is to add quotes around booleans.
| cache: | ||
| description: Used to specify whether caching is needed. Set to true, if you'd like to enable caching. | ||
| default: true | ||
| default: 'true' |
There was a problem hiding this comment.
This is a yaml file and github's action syntax asserts that the default field is a string, but true (and false) would be parsed as booleans by yaml parsers which makes parsers very upset.
The correct thing to do to make the parsers happy is to add quotes around booleans.
| // httm | ||
| // httpm | ||
| httpmGetJsonSpy = jest.spyOn(httpm.HttpClient.prototype, 'getJson'); |
There was a problem hiding this comment.
Comments should match code, so this fixes the comment to match the code.
| }); | ||
|
|
||
| it('can find 1.9.7 from manifest on osx', async () => { | ||
| it('can find 1.9.7 from manifest on macOS', async () => { |
There was a problem hiding this comment.
osx was never the correct name for the brand so this changes it to use the current one
| }); | ||
|
|
||
| it('adds bin if dir not exists', async () => { | ||
| it('adds bin if dir does not exist', async () => { |
There was a problem hiding this comment.
nonexistent might be better, but this test description doesn't actually make sense.
Why would anyone add a bin directory if it doesn't exist?
it might be better to write if missing, if that's what it's trying to achieve.
| }); | ||
|
|
||
| it('fallback to dist if version is not found in manifest', async () => { | ||
| it('fall back to dist if version is not found in manifest', async () => { |
There was a problem hiding this comment.
fallback is a noun, but this phrase wants the verb (phrase) which is fall back.
2 participants
Description:
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/setup-go/actions/runs/12589953413#summary-35090680468
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/setup-go/actions/runs/12589953488#summary-35090680749
Related issue:
Add link to the related issue.
Check list: