Skip to content

[LUADNS] Fix example keyword arguments #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aaron-sierra wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[LUADNS] Fix example keyword arguments #2064

aaron-sierra wants to merge 1 commit into from
+1 −1

Conversation

@aaron-sierra
Copy link

@aaron-sierra aaron-sierra commented Mar 25, 2025

[LUADNS] Fix example keyword arguments

Description

Correct the example keyword arguments to allow successful login.

Function Original Proposed
Username user= key=
Password key= secret=

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

docs: luadns: Fix example keyword arguments
b6d1488 
Change "key=" to "secret=" and "user=" to "key=".
micafer
micafer approved these changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@micafer micafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micafer micafer added this to the v3.9.1 milestone Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micafer micafer micafer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@aaron-sierra @micafer