Detect vendor before crafting cdiDeviceIDs for --gpus #4728
+295
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv-tyagi
force-pushed
the
detect-vendor-id
branch
from
2b035ba to
087ebbf
Compare
Author
|
Can someone help me explain these test failures? These don't seem to be related to the changes in the PR. |
AkihiroSuda
reviewed
Feb 4, 2026
Member
There was a problem hiding this comment.
https://github.com/containerd/nerdctl/blob/main/docs/gpu.md should be updated too?
Author
There was a problem hiding this comment.
Can we do that in a follow up?
Once this is merged, we might organise our docs better and put the latest links here to help users install the AMD CDI specs through amd-ctk.
Author
There was a problem hiding this comment.
I have updated the documentation in this PR itself. PTAL whenever you get time.
cc @elezar
shiv-tyagi
force-pushed
the
detect-vendor-id
branch
2 times, most recently
from
138f373 to
0e65876
Compare
Author
|
I have added the |
shiv-tyagi
force-pushed
the
detect-vendor-id
branch
2 times, most recently
from
a945e3c to
9ad72de
Compare
This detects the GPU vendor from the CDI spec files while generating devicesIDs corresponding to the values passed to --gpus option. With this, the users can also use AMD gpus if a corresponding CDI spec is present. Signed-off-by: Shiv Tyagi <Shiv.Tyagi@amd.com>
shiv-tyagi
force-pushed
the
detect-vendor-id
branch
from
9ad72de to
4649baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detects the GPU vendor from the CDI spec files while generating devicesIDs corresponding to the values passed to
--gpusoption. With this, the users can also use AMD gpus if a corresponding CDI spec is present.Here is a similar PR for ctr containerd/containerd#12839