Skip to content

Conversation

@adityachoudhari26
Copy link
Member

@adityachoudhari26 adityachoudhari26 commented Feb 10, 2026

Summary by CodeRabbit

  • Chores

    • Bumped chart version to 0.10.0
  • Configuration

    • Restructured Kafka settings into a nested global Kafka block for clearer configuration
    • Added new Kafka connection parameters (group and topic) for the workspace engine
  • Documentation

    • Helm install/upgrade notes now include an Azure integration status block to surface secret/config warnings and success messages

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Chart version bumped to 0.10.0. Kafka configuration changed from a flat global.kafkaBrokers string to a nested global.kafka map (brokers, groupId, topic). StatefulSet template updated to use the new paths and expose KAFKA_BROKERS, KAFKA_GROUP_ID, and KAFKA_TOPIC. NOTES.txt gains an Azure integration status block.

Changes

Cohort / File(s) Summary
Version Update
charts/ctrlplane/Chart.yaml
Bumped chart version from 0.9.3 to 0.10.0.
Kafka configuration & runtime env
charts/ctrlplane/values.yaml, charts/ctrlplane/charts/workspace-engine/templates/statefulset.yaml
Replaced global.kafkaBrokers with global.kafka map (brokers, groupId, topic). StatefulSet now reads .Values.global.kafka.brokers and adds KAFKA_GROUP_ID and KAFKA_TOPIC env vars alongside KAFKA_BROKERS.
Helm notes / integrations
charts/ctrlplane/templates/NOTES.txt
Added an Azure integration status block gated by .Values.global.integrations.azure, showing success/warning based on how azure.appClientSecret is provided. Existing GitHub bot block unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • jsbroks
  • zacharyblasczyk

Poem

🐰 I hopped through charts with nimble paws,
Brokers nested now, no more flaws,
Env vars added, notes now say,
Azure checks hop into play,
Version raised — a tidy cause. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: restructuring Kafka configuration and adding new Kafka-related environment variables and configuration options across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kafka-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@charts/ctrlplane/values.yaml`:
- Around line 62-65: The chart introduced a breaking key rename so existing
overrides of global.kafkaBrokers will be ignored; update the chart to detect and
handle the old key by adding a validation or compatibility layer: add a
templated check (e.g., in templates/_helpers.tpl or a new
templates/validation.yaml) that fails install/upgrade with a clear error if
global.kafkaBrokers is set, or populate kafka.brokers from global.kafkaBrokers
when present to preserve backward compatibility, and document the change in the
README/CHANGELOG; reference the values keys global.kafkaBrokers and
kafka.brokers and the values.yaml defaults when implementing this.

Comment on lines +62 to +65
kafka:
brokers: localhost:9092
groupId: workspace-engine
topic: workspace-events
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Breaking change: existing overrides of global.kafkaBrokers will silently stop working.

Users who have global.kafkaBrokers in their custom values.yaml or --set flags will not get an error — the old key will simply be ignored, and the new defaults will apply. Consider documenting this migration in the chart's changelog or README, and optionally adding a validation template that fails with a helpful message if the old key is still set.

🤖 Prompt for AI Agents
In `@charts/ctrlplane/values.yaml` around lines 62 - 65, The chart introduced a
breaking key rename so existing overrides of global.kafkaBrokers will be
ignored; update the chart to detect and handle the old key by adding a
validation or compatibility layer: add a templated check (e.g., in
templates/_helpers.tpl or a new templates/validation.yaml) that fails
install/upgrade with a clear error if global.kafkaBrokers is set, or populate
kafka.brokers from global.kafkaBrokers when present to preserve backward
compatibility, and document the change in the README/CHANGELOG; reference the
values keys global.kafkaBrokers and kafka.brokers and the values.yaml defaults
when implementing this.

@adityachoudhari26 adityachoudhari26 merged commit b82ee66 into main Feb 10, 2026
3 of 4 checks passed
@adityachoudhari26 adityachoudhari26 deleted the kafka-configuration branch February 10, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant