store: Fix iterator bug in fields_exist_in_dest for multi-column indexes #6341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fields_exist_in_dest used a single consuming iterator over table columns and checked each index column with .any(), which advances the iterator. When index columns appeared in a different order than the table columns, later lookups would miss columns the iterator had already passed, causing valid multi-column indexes to be silently dropped during subgraph copy/graft. Replace the consuming iterator with direct lookups on dest_table.columns for each column check, so column order no longer matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fields_exist_in_destused a single consuming iterator over table columns and checked each index column with .any(), which advances the iterator. When index columns appeared in a different order than the table columns, later lookups would miss columns the iterator had already passed, causing valid multi-column indexes to be silently dropped during subgraph copy/graft.Replace the consuming iterator with direct lookups on dest_table.columns for each column check, so column order no longer matters.