Add Counterexamples to Refinement Errors #146
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds counterexamples to refinement errors by extracting the SMT model from Z3.
Changes
getCounterexamplemethod toTranslatorToZ3that extracts variable assignments (for constants only)SMTEvaluator, when the SMT returnsSATwe get the SMT model and throw theTypeCheckErrorcontaining the counterexamplebooleanit now returnsCounterexample- if counterexample is null, then the check succeeded, otherwise it failedRefinementError, we override thegetDetailsmethod to add the counterexamples as extra information in the error message. Also, it filters out fresh variables which don't even exist in the source code, and if the counterexample is the same as the found type (already included in the message), then the counterexample is not shown.Examples
These will need improvements in the future, especially when dealing with ghosts: