Enhancing the delay in the listener when there is exception in the connection #5448
+616
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
surajitshil-03
changed the title
surajitshil-03
changed the title
rishabhmalikMS
approved these changes
Jan 14, 2026
rajmishra1997
approved these changes
Jan 14, 2026
Contributor
rajmishra1997
left a comment
rajmishra1997
left a comment
There was a problem hiding this comment.
Suggestion: For higher number of error response from server, can we add log/warning to display continuous error response received
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
surajitshil-03
commented
Jan 20, 2026
raujaiswal
reviewed
Jan 20, 2026
raujaiswal
reviewed
Jan 20, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MantavyaDh
reviewed
Jan 21, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
surajitshil-03
force-pushed
the
users/surajitshil/retryLogic
branch
from
ad39d51 to
16a1ba3
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MantavyaDh
reviewed
Jan 28, 2026
Contributor
|
Please explore how we can simplify the currently spreaded logic of retries. If possible, we can have common function for calculating retry delay which we are having and multiple places in message listener right now. |
Contributor
|
we are not enabling FF to RM here in the PR , could you please check if do we need. https://dev.azure.com/mseng/AzureDevOps/_git/AzureDevOps/pullrequest/891094?_a=files |
… calls and also added a FF for the changes
…st cases accordingly
surajitshil-03
force-pushed
the
users/surajitshil/retryLogic
branch
from
2ab1629 to
6be937b
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
surajitshil-03
force-pushed
the
users/surajitshil/retryLogic
branch
from
b7977f4 to
05c42b5
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sanjuyadav24
approved these changes
Feb 3, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding a delay in the Agent listener code before retrying request when there is a retriable exception thrown from the server side.
Related work-item: AB#2338439
Description
When the server is unavailable (not an authentication error), the server returns a different exception (e.g., VssServiceResponseException with status code 404). The agent continuously retries the request indefinitely. Each retry invokes the OAuth token provisioning mechanism on the server (the server checks whether there is any cached token or not else it creates one). This behavior significantly increases load on an already unavailable server.
Hence we have increased the Backoff delay in the agent code before retrying the requests. We have implemented an exponential backoff delay which is capped at 5 minutes and all the changes are behind a Feature flag so that the execution can be controlled.
Risk Assessment (Low / Medium / High)
Low
Unit Tests Added or Updated (Yes / No)
Yes added L0 test cases for the delay behaviour in 3 methods CreateSessionAsync, GetNextMessageAsync and KeepAlive based on the state of the feature flag added.
Additional Testing Performed
Manually tested connecting the agent with devfabric and then stopping the tfs devfabric web service. The agent delayed the request based on the continuous error count.
For the main listener loop:
For the Keep Alive Call:
For Create Session Call:
[when there is session conflict]
Change Behind Feature Flag (Yes / No)
No
Tech Design / Approach
This is done to reduce the load on the server where the agent continuously make requests to the server.
Documentation Changes Required (Yes/No)
No
Logging Added/Updated (Yes/No)
NA
Telemetry Added/Updated (Yes/No)
NA
Rollback Scenario and Process (Yes/No)
NA
Dependency Impact Assessed and Regression Tested (Yes/No)
NA