Fix for removing erratic jittering during scrolling/zooming #7704
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is set to `false` in `zoomWheel`'s redrawTimer, but a corresponding set to `true` was missing.
This prevents multiple subplots from firing their `setTimeout` callback which otherwise leads to erratic jumps in the plots when scrolling/zooming with the mouse while moving it at the same time.
alexcjohnson
reviewed
Feb 6, 2026
src/plots/cartesian/dragbox.js
Outdated
| CURRENT_SCROLLING_SUBPLOT = plotinfo.id; | ||
| } | ||
| // Early exit to prevent jitters if this subplot didn't initiate the scroll | ||
| if (CURRENT_SCROLLING_SUBPLOT !== plotinfo.id) { |
Collaborator
There was a problem hiding this comment.
IIRC this id is just the two axis ids concatenated, like x2y2, yes? What would happen if you put two plot divs next to each other, each with just one x and one y axis, and you do the same kind of move but now from one div to the other? Where I'm coming from is typically we attach state variables like this (and like _replotting) to the div (gd) rather than having a single one for the whole library.
Author
There was a problem hiding this comment.
You are right, plotinfo.id could come up multiple times over different plots. Is it OK if I store _currentScrollingSubplot in gd by setting it directly like here: a9f1218
(Also added the new attribute to purge in plots.js)
When multiple *plots* (i.e. multiple `gd`s) are present, `plotinfo.id` can actually appear in both plots, and thus the global reference would incorrectly store the state of the other plot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two sources of erratic zooming behavior.
The first issue is documented here: #7494
Especially in charts that use auto margins, the plot area updates "erratically," i.e. with visual jumps. This issue can be solved by correctly setting the
_replottingflag inzoomWheel, which causesplots.autoMargin(plots.js) to skip its calculation.Before this PR,
zoomWheel'ssetTimeoutcallback just set this flag tofalsewithout setting it totruebefore.The 2nd issue reveals itself when multiple subplots are present: When zooming while moving the cursor to a different subplot, multiple subplots fire their
updateSubplotswith slightly different viewboxes which leads to visual jumping. The issue appears more frequently on data-intensive charts.Note that this is very hard to replicate with a trackpad. It's best to test this with a free-spinning mouse wheel.
second_issue.json
(Start zooming on one subplot, and move the mouse onto another subplot while continuing zooming.)
second_issue.mp4