Fix grains-msgpack #68700
Draft
Fix grains-msgpack #68700
+101
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handles corrupted grains cache msgpack data by safely loading cached grains, invalidating bad cache files, and refreshing grains instead of crashing. Adds msgpack error helpers and unit tests.
What issues does this PR fix or reference?
Fixes #68678
Previous Behavior
A corrupted grains cache could raise SaltDeserializationError, causing repeated CRITICAL failures during grains refresh.
New Behavior
Grains cache deserialization failures are handled gracefully: the cache is removed, grains refresh continues, and the minion stays healthy.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No