Include minion ID in rejected authentication warning #68702
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When minimum_auth_version rejects a connection attempt, the warning message now includes the minion ID (extracted from the payload load). This allows administrators to quickly identify which minions are using outdated protocol versions and need upgrading. If the payload load is encrypted (not a dict), the message falls back to 'unknown minion' to avoid errors. Fixes saltstack#68671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the
minimum_auth_versionrejection warning insalt/channel/server.pyto include the minion ID. This helps administrators identify which minions are using outdated protocol versions and need to be upgraded.Before this change, the warning only showed the protocol version numbers:
After this change, the warning includes the minion ID:
If the payload is encrypted (load is not a dict), the message falls back to
'unknown minion'.What issues does this PR fix or reference?
Fixes #68671
Previous Behavior
The rejected authentication warning did not include the minion ID, making it difficult for administrators to identify which minion needed upgrading, especially in environments with many minions.
New Behavior
The warning now includes the minion ID extracted from the payload, allowing administrators to quickly identify and upgrade the affected minion.
Merge requirements satisfied?
Commits signed with GPG?
No